playwright-community / heroku-playwright-buildpack

Buildpack for running Playwright with Chromium and Firefox on Heroku.
https://heroku.playwright.tech
48 stars 47 forks source link

Add heroku-22 stack support #20

Closed xiexieeric closed 1 year ago

xiexieeric commented 2 years ago

Tested with a heroku-22 stack in my own project. Seems to work fine. Could others test it out too?

Also added a warning regarding playwright-chromium version 1.15 being the last supported version

xiexieeric commented 2 years ago

@mxschmitt Pinging you for attention. First time making a PR into open source!

brent-yearone commented 2 years ago

I totally need this patch -- I'm hoping to run playwright on Heroku-22.

Thank you, @xiexieeric, for putting it together! 谢谢你!

lippytak commented 2 years ago

@xiexieeric thanks for putting this together!

Everything seems to build correctly for me, but when I try to run playwright.chromium.launch I still get this error: playwright._impl._api_types.Error: Executable doesn't exist at /app/.heroku/python/lib/python3.10/site-packages/playwright/driver/package/.local-browsers/chromium-1019/chrome-linux/chrome

Same result with playwright.firefox.launch: playwright._impl._api_types.Error: Executable doesn't exist at /app/.heroku/python/lib/python3.10/site-packages/playwright/driver/package/.local-browsers/firefox-1344/firefox/firefox

I'm just running this buildback and then the standard heroku/python.

Any idea what might be going on / suggestions? Appreciate any help.

(+ @brent-yearone in case you got things working)

OmarSaidIbrahim commented 2 years ago

Does this change fix the error I get when trying to deploy it on heroku ? issue #23

granth commented 1 year ago

The browser can be installed with a heroku-cleanup script in package.json.

"scripts": {
  "heroku-cleanup": "yarn run playwright install chromium"
}

It would be nicer to have it in the buildpack, though.

garcia-marco commented 1 year ago

Up

pistachiomatt commented 1 year ago

Is this repo being maintained?

boblauer commented 1 year ago

@xiexieeric This worked beautifully, thank you!

For anyone else who wants to try it, you can use this url for your buildpack:

https://github.com/Nitra-Finance/heroku-playwright-buildpack#518fad4074f26aeef0c1fb5d5bfaed41ae2f629e