search

playwright-community / heroku-playwright-buildpack

Buildpack for running Playwright with Chromium and Firefox on Heroku.
https://heroku.playwright.tech
48 stars 47 forks source link

Add support for heroku 24 stack #28

Open jasonsbrooks opened 3 months ago

jasonsbrooks commented 3 months ago

Adds support for the heroku-24 stack.

Note - this seems to be blocked by issues mentioned in https://github.com/microsoft/playwright/issues/30368 . Facing an error when pushing due to libasound2. Submitting this as a draft to refer to in the associated issue.

theodorton commented 1 month ago

@jasonsbrooks I was able to get this to work on Heroku with Playwright 1.48 by correcting the libasound2 on the 24 stack: https://github.com/Skalar/heroku-playwright-buildpack/commit/19851ad82eab4baf4fe032907aab5a104e087332

Any reason you had to override the apt buildpack? I would like to create a PR with my changes, but not sure if the override should be included.