playwright-community / heroku-playwright-buildpack

Buildpack for running Playwright with Chromium and Firefox on Heroku.
https://heroku.playwright.tech
48 stars 47 forks source link

Support for heroku-24 stack #29

Open jasonsbrooks opened 3 months ago

jasonsbrooks commented 3 months ago

I'm attempting to update this repo to support the heroku-24 stack. In doing so, I ran into issues installing the libasound2 dependency. It seems related to some of the same issues mentioned in https://github.com/microsoft/playwright/issues/30368. I'm using python playwright version 1.45.1.

Draft PR: https://github.com/playwright-community/heroku-playwright-buildpack/pull/28

Here's the stack trace from heroku when installing with the updates from the PR:

remote: -----> Installing System Dependencies
remote: Cloning into '.'...
remote: Installing Playwright dependencies (env: PLAYWRIGHT_BUILDPACK_BROWSERS) for chromium.
remote: -----> Detected Aptfile or Stack changes, flushing cache
remote: -----> Updating APT package index
remote:        Get:1 http://archive.ubuntu.com/ubuntu noble InRelease [256 kB]
remote:        Get:2 http://security.ubuntu.com/ubuntu noble-security InRelease [126 kB]
remote:        Get:3 http://archive.ubuntu.com/ubuntu noble-updates InRelease [126 kB]
remote:        Get:4 http://archive.ubuntu.com/ubuntu noble-backports InRelease [126 kB]
remote:        Get:5 http://security.ubuntu.com/ubuntu noble-security/main amd64 Packages [330 kB]
remote:        Get:6 http://archive.ubuntu.com/ubuntu noble/universe amd64 Packages [19.3 MB]
remote:        Get:7 http://security.ubuntu.com/ubuntu noble-security/universe amd64 Packages [329 kB]
remote:        Get:8 https://apt.postgresql.org/pub/repos/apt noble-pgdg InRelease [129 kB]
remote:        Get:9 http://archive.ubuntu.com/ubuntu noble/main amd64 Packages [1,808 kB]
remote:        Get:10 http://archive.ubuntu.com/ubuntu noble-updates/universe amd64 Packages [424 kB]
remote:        Get:11 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages [400 kB]
remote:        Get:12 http://archive.ubuntu.com/ubuntu noble-backports/universe amd64 Packages [11.5 kB]
remote:        Get:13 https://apt.postgresql.org/pub/repos/apt noble-pgdg/main amd64 Packages [468 kB]
remote:        rm: cannot remove '/var/cache/apt/archives/partial/*.deb': Permission denied
remote:        Fetched 23.9 MB in 1s (23.6 MB/s)
remote:        Reading package lists...
remote: -----> Fetching .debs for libnspr4
remote:        Reading package lists...
remote:        Building dependency tree...
remote:        0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 21 not upgraded.
remote:        Need to get 117 kB of archives.
remote:        After this operation, 0 B of additional disk space will be used.
remote:        Get:1 http://archive.ubuntu.com/ubuntu noble/main amd64 libnspr4 amd64 2:4.35-1.1build1 [117 kB]
remote:        Fetched 117 kB in 0s (293 kB/s)
remote:        Download complete and in download only mode
remote: -----> Fetching .debs for libnss3
remote:        Reading package lists...
remote:        Building dependency tree...
remote:        0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 21 not upgraded.
remote:        Need to get 1,445 kB of archives.
remote:        After this operation, 0 B of additional disk space will be used.
remote:        Get:1 http://archive.ubuntu.com/ubuntu noble/main amd64 libnss3 amd64 2:3.98-1build1 [1,445 kB]
remote:        Fetched 1,445 kB in 0s (8,926 kB/s)
remote:        Download complete and in download only mode
remote: -----> Fetching .debs for libxss1
remote:        Reading package lists...
remote:        Building dependency tree...
remote:        The following NEW packages will be installed:
remote:          libxss1
remote:        0 upgraded, 1 newly installed, 0 to remove and 21 not upgraded.
remote:        Need to get 7,204 B of archives.
remote:        After this operation, 31.7 kB of additional disk space will be used.
remote:        Get:1 http://archive.ubuntu.com/ubuntu noble/main amd64 libxss1 amd64 1:1.2.3-1build3 [7,204 B]
remote:        Fetched 7,204 B in 0s (42.8 kB/s)
remote:        Download complete and in download only mode
remote: -----> Fetching .debs for libasound2
remote:        Reading package lists...
remote:        Building dependency tree...
remote:        Package libasound2 is a virtual package provided by:
remote:          liboss4-salsa-asound2 4.2-build2020-1ubuntu3
remote:          libasound2t64 1.2.11-1build2 (= 1.2.11-1build2)
remote:        
remote: E: Package 'libasound2' has no installation candidate
remote:  !     Push rejected, failed to compile Playwright app.
remote: 
remote:  !     Push failed
remote: Verifying deploy...
remote: 
remote: !       Push rejected to ....
remote: 
To https://git.heroku.com/...