clients lock up - Githubissues

plaza-in-a-heatwave / Cadesim

The cadesim server and client, inspired by Puzzle Pirates.

1 stars 1 forks source link

Closed plaza-in-a-heatwave closed 4 years ago

plaza-in-a-heatwave commented 4 years ago

Witnessed this - the clock still runs but the controls are unusable. Ships can't move and I was unable to move or type from the safe zone.

Potential fixes - don't lock the clients up, or give them the means to unlock intelligently

8 ships on the board at the time (4v4)

plaza-in-a-heatwave commented 4 years ago

Ships were sinking at the time. Could this be related to a ship sinking in the 4th movement phase?

plaza-in-a-heatwave commented 4 years ago

Contingency solutions - can either disable the client locking, or force unlock after a constant amount of seconds.

force unlock - this may cause problems with earlier bugfixes which reset all tokens after the move has been played.
force unlock after n seconds - could be e.g. 15s, but still risky if the turn duration is set below 15s.

plaza-in-a-heatwave commented 4 years ago

Related: at the end of the round clients all lock up. However as soon as my ship left the safe zone the clients unlocked again

plaza-in-a-heatwave commented 4 years ago

assuming this is fixed - locking was re-entrant running the "unlock" sequence continuously. Closing, will re-open if it reoccurs