plaza-in-a-heatwave / Cadesim

The cadesim server and client, inspired by Puzzle Pirates.
1 stars 1 forks source link

client glitches #52

Closed plaza-in-a-heatwave closed 4 years ago

plaza-in-a-heatwave commented 4 years ago

Bug 1

Clicking/dragging can occasionally crash the client and/or cause the server to kick the player.

Bug 2

Closing the server doesn't result in an instant disconnect. This is caused by the wrong thread attempting to call context.dispose() in ClientConnectionTask.java.

java.lang.RuntimeException: No OpenGL context found in the current thread.
    at org.lwjgl.opengl.GLContext.getCapabilities(GLContext.java:124)
    at org.lwjgl.opengl.GL11.glDeleteTextures(GL11.java:732)
    at com.badlogic.gdx.backends.lwjgl.LwjglGL20.glDeleteTexture(LwjglGL20.java:248)
    at com.badlogic.gdx.graphics.GLTexture.delete(GLTexture.java:170)
    at com.badlogic.gdx.graphics.Texture.dispose(Texture.java:198)
    at com.badlogic.gdx.graphics.g2d.PixmapPacker$Page$1.dispose(PixmapPacker.java:380)
    at com.badlogic.gdx.graphics.g2d.BitmapFont.dispose(BitmapFont.java:317)
    at com.benberi.cadesim.game.scene.impl.battle.SeaBattleScene.dispose(SeaBattleScene.java:661)
    at com.benberi.cadesim.GameContext.dispose(GameContext.java:384)
    at com.benberi.cadesim.client.ClientConnectionTask.run(ClientConnectionTask.java:65)

Bug 3

Clicking/dragging during the animation phase locks you out from the controls.

plaza-in-a-heatwave commented 4 years ago

Bug 1 fixed in this commit Bug 2 fixed as part of this commit but reverted in this commit and reapplied in this commit.

plaza-in-a-heatwave commented 4 years ago

Readded Bug 3 - controls lock up.

plaza-in-a-heatwave commented 4 years ago

Bug 3 fixed in this commit

plaza-in-a-heatwave commented 4 years ago

Bug 3 still repeatable in 1.9.92 - occasionally all button click/right click controls in the shiphand freeze up and you can only drag onto it.

David52920 commented 4 years ago

Bug 1 fixed in this commit Bug 2 fixed as part of this commit but reverted in this commit and reapplied in this commit.

Bug 1: I think still occurs, not sure, randomly crashes without a warning. Not easy to replicate.

David52920 commented 4 years ago

Bug 3: this seems to happen when getting sunk as well occasionally.

plaza-in-a-heatwave commented 4 years ago

Created a new issue #80 for bug 3.