plazi / ggxml2taxpub

Conversion of GoldenGATE XML to JATS/TaxPub at treatment level
0 stars 1 forks source link

validation of taxpub provided by GG service #36

Open tcatapano opened 2 years ago

tcatapano commented 2 years ago

Nota bene that the results of the transformations provided by the service at https://tb.plazi.org/GgServer/taxPubL1/ may be invalid. In fact it is likely than many will be invalid due to other issues logged in this repository. This can be handled in two ways (not exclusive):

  1. consumers perform validation against a copy of the TaxPub DTD provide at: https://github.com/plazi/TaxPub/releases/tag/v1.0.0-rc2
  2. as mentioned in https://github.com/plazi/ggxml2taxpub-treatments/issues/20#issuecomment-1025208498_, Plazi will add a step to the service at https://tb.plazi.org/GgServer/taxPubL1/ which performs DTD validation, passing through valid instances and producing an error for invalid instances
gsautter commented 2 years ago

@tcatapano thought we agreed that the TaxPub created on demand in the website shouldn't be validated, and that validation should happen only on a push export from the back-end (once SiB provide us with a place to push to) and, should we introduce that, also on export to Zenodo and to TaxPub formatted collection dumps.

tcatapano commented 2 years ago

@gsuatter: I think its fine to perform the validation on the export and not through the on-demand service. That still leaves option 1 above, for consumers to handle the validation (if even necessary) on their end of the on-demand pulls.

tcatapano commented 2 years ago

Ive posted a list of URLs to the known valid TaxPub files (i.e., those under level1/ in this repo) here:

https://github.com/plazi/ggxml2taxpub-treatments/blob/main/valid_level1.txt

I hope this will be helpful for development purposes.