search

plentz / lol_dba

lol_dba is a small package of rake tasks that scan your application models and displays a list of columns that probably should be indexed. Also, it can generate .sql migration scripts.
1.59k stars 69 forks source link

Fix db:migrate_sql with Rails 5+ #95

Closed cmason closed 6 years ago

cmason commented 6 years ago

In Rails 5.0 - 5.1, ActiveRecord::Migrator.migrations_path is pluralized. In Rails 5.2, migrations must be accessed through ActiveRecord::MigrationContext

This fixes issue https://github.com/plentz/lol_dba/issues/94

plentz commented 6 years ago

@cmason awesome! I just asked a thing about the version check, but besides that, everything is 👌

plentz commented 6 years ago

@cmason hey! I've added rails 5.2 @ master, can you update your PR? btw, I think we can use Gem::Version.new('5.2.0') because I really don't want to support RC versions (and not 5.2.0 is officially out).

plentz commented 6 years ago

@cmason thanks a lot! I'm working a bit in the last few days to improve lol_dba code. last night I did this 75705a5624724f0b3fb2baccfa457e2cf16e7d09 which I think will make this kind of changes easier in the future :)

cmason commented 6 years ago

Looks good!

On Thu, May 3, 2018 at 5:32 AM Diego Plentz notifications@github.com wrote:

@cmason https://github.com/cmason thanks a lot! I'm working a bit in the last few days to improve lol_dba code. last night I did this 75705a5 https://github.com/plentz/lol_dba/commit/75705a5624724f0b3fb2baccfa457e2cf16e7d09 which I think will make this kind of changes easier in the future :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/plentz/lol_dba/pull/95#issuecomment-386253051, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC41h8xE2zgjpmLH4XOKiCrf9Wxcojsks5tuty5gaJpZM4S5cx8 .

-- Chris Mason Software Architect www.chaione.com http://www.chaione.com/ | O: 888-316-0357 <//888-316-0357;102> | @chaione https://twitter.com/chaione 1800 West Loop South #2100, Houston, TX 77027

ChaiOne: Digital Innovation Agency