plk / biblatex-apa

APA style for BibLaTeX
90 stars 48 forks source link

Simplify annotation (#126) #158

Closed moewew closed 2 years ago

moewew commented 2 years ago

With the as of now biblatex-apa-only appendunit we can even avoid the punctuation buffer trickery.

See also #127. Ping https://github.com/plk/biblatex/issues/1048.

plk commented 2 years ago

Hmm, I'm getting a period after the URL in the @INBOOK APA example but not the @ARTICLE examples in the APA test with this patch. Should be no period for either. Not obvious where this coming from but could be related to #141?

moewew commented 2 years ago

I'm guessing #141 plays a role here, yes. Do you have an example where things are worse with this PR merged compared to before it was merged? (Either an entry in biblatex-apa-test or an MWE?)

plk commented 2 years ago

With the patch, compare example 9.51:1 and 9.51:2 in the references test .bib - they should both be without period as per the reference.pdf but with the patch, 9.51:1 has a period.

moewew commented 2 years ago

I see. On the other hand the PR here fixes

\documentclass[american]{article}
\usepackage[T1]{fontenc}
\usepackage{babel}
\usepackage{csquotes}

\usepackage[backend=biber, style=apa]{biblatex}

\begin{filecontents}{\jobname.bib}
@book{elk,
  author     = {Anne Elk},
  title      = {A Theory on Brontosauruses},
  year       = {1972},
  publisher  = {Monthy \& Co.},
  location   = {London},
  addendum   = {Flob},
  annotation = {Blorb},
}
\end{filecontents}
\addbibresource{\jobname.bib}
\addbibresource{biblatex-examples.bib}

\begin{document}
Lorem \autocite{sigfridsson,elk}

\printbibliography
\end{document}

where I'd expect a period after "Flob".

Swings and roundabouts.

If we can fix #141 for good, that should also make 9.51:1 work properly again.