plk / biblatex-apa

APA style for BibLaTeX
90 stars 48 forks source link

nodate and other literals in danish-apa.lbx #161

Closed Hen-Rex closed 2 years ago

Hen-Rex commented 2 years ago

Hi @plk

I noticed that a lot of the literals / bibliography strings in danish-apa.lbx have no translation and are marked with "% FIXME".

Also, the "nodate" string is missing entirely from danish-apa.lbx

Do you need help translating these into Danish and is there a reason why "nodate" is missing?

Hen-Rex commented 2 years ago

I tried adding "nodate" into danish-apa.lbx, but for some reason it does not make any difference? How come?

nodate = {{s\adddot d\adddot}{s\adddot d\adddot}},

plk commented 2 years ago

Yes, if there are any %FIXME, this means any contribution to these translations is appreciated. nodate isn't defined by the APA style, it's a biblatex core localisation string - you'll find it in the danish.lbx in the biblatex distribution.

Hen-Rex commented 2 years ago

Hi

I have made the changes and fixed all Danish FIXME strings. I am not an avid user of Github so I don't know if I can just merge these changes?

As for "nodate", it does appear in the biblatex danish.lbx file, but documents still write "nodate" in the list of references despite of this:

\DeclareLanguageMapping{danish}{danish-apa}

Looking at spanish-apa.lbx of the biblatex-apa package - it also has a separate "nodate" string. If I declare my language mapping to spanish-apa it works (but in Spanish):

\DeclareLanguageMapping{danish}{spanish-apa}

I have tried adding a nodate translation in danish-apa.lbx, but it does not work. Editing nodate in spanish-apa.lbx does work. So I don't know why Spanish works, but not Danish.

plk commented 2 years ago

In github, you can just make a "pull request" that I can merge. Are you using the latest APA style version? You don't need the \DeclareLanguageMapping and this may just override the biblatex strings if they are present (spanish is an anomaly) which explains the issue you are seeing.

Hen-Rex commented 2 years ago

I have made the pull request now. I added the "nodate" literal, but could not figure out how to edit the commit since it did not allow me to do so.

I have an additional question. biblatex's standard danish.lbx file already contains references to:

But danish-apa.lbx only references:

Isn't that an issue? Should danish-apa.lbx and the remaining language files belonging to biblatex-apa drop its own translations in favor of the standard biblatex translations found in the normal biblatex repo?

Hen-Rex commented 2 years ago

Hi, sorry if you received a lot of notifications. I was trying to figure out how to commit from my own Github branch to the master branch.

In addition to fixing the standard biblatex danish.lbx I have also added all missing translations to biblatex-apa danish-apa.lbx

Most importantly, I wish to advise that:

Hen-Rex commented 2 years ago

Yes, it seems the 'nodate' issue stems from an outdated version of biblatex-apa.lbx that I used. I updated to the latest version of biblatex and biblatex-apa, which seems to have resolved the issue.