plk / biblatex

biblatex is a sophisticated bibliography system for LaTeX users. It has considerably more features than traditional bibtex and supports UTF-8
520 stars 118 forks source link

Adapt to expl3 case changing change #1310

Closed moewew closed 1 year ago

moewew commented 1 year ago

we no longer use \text_titlecase:n for sentence casing.

See https://github.com/latex3/latex3/pull/1247.

josephwright commented 1 year ago

Looks good to me

moewew commented 1 year ago

Seemed to work fine in my tests also with the updated kernel.

moewew commented 1 year ago

Urgh! So close... There is a failure in the test for https://github.com/plk/biblatex/issues/1234. Need to investigate.

moewew commented 1 year ago

Seems this is not primarily a biblatex issue @josephwright. Consider

\documentclass[british]{article}
\usepackage[T1]{fontenc}
\usepackage[utf8]{inputenc}
\usepackage{babel}
\usepackage{etoolbox}

\begin{document}
\newrobustcmd*{\hello}{hello}
\newrobustcmd*{\helloA}{helloA}
\newrobustcmd*{\helloB}{helloB}
\newrobustcmd*{\helloC}{helloC}
\newrobustcmd*{\helloD}{helloD}
\DeclareCaseChangeEquivalent{\hello}{%
     \CaseSwitch
       {\helloA}
       {\helloB}
       {\helloC}
       {\helloD}}

\MakeLowercase{\hello}

\MakeUppercase{\hello}

\MakeTitlecase{\hello}
\end{document}

which gives me

helloC helloB helloC

image of output reproduced above with the updated kernel.

Overleaf with the old kernel (https://www.overleaf.com/read/xbmyvpvkzchp#aaeb2c) has

helloC helloB helloD

Is that intentional?