plomino / Plomino

Powerful and flexible web-based application builder
33 stars 37 forks source link

Validation errors should be shown on the same page #766

Open displacedaussie opened 8 years ago

displacedaussie commented 8 years ago

Problem

In Plomino 2, validation errors are shown on a different page after submit. The user must click Back to return to the form. In Plomino 1 this was handled via a popup which blocked submission and displayed the validation errors.

This isn't very user friendly. Ideally the errors should be shown on the same page like normal validation/errors in Plone and fields that have failed validation should be highlighted. The errors should either be shown at the top of the page (with links to the failed fields), or the errors should be inline.

This is done in multipage by handling traversal/redirection and then injecting page_errors, but could be generalised to all forms.

Options

con: this doesn't work nicely if the user doesn't have JavaScript

displacedaussie commented 8 years ago

@ebrehault The current method for handling errors is one of the first things that our users notice. In particular they complain about/are surprised by:

Is there a reason that Plomino doesn't do something closer to the way plone normally handles form errors?

djay commented 8 years ago

I think where possible plomino should handle interactions with progressive enhancement, so we shouldn't have an AJAX only way of handling errors.