search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
246 stars 187 forks source link

PLIP: Remove plone.app.openid from core #1659

Closed jensens closed 8 years ago

jensens commented 8 years ago

Proposer : Jens Klein

Seconder : Johannes Raggam

Abstract

plone.app.openid is an old OpenID implementation for Plone used by very few users.

Motivation

It is rarely used and should live as an addon. Also nowadays there are better and more flexible implementations for OpenID supporting many other protocols, like the more widespread OAuth2: pas.plugins.authomatic. We do not want to maintain it any more. It reduces the number of packages in Plone. Also we get rid of a warning while start-up.

Assumptions

Nothing needs to happen before this PLIP.

Proposal & Implementation

Remove from sources.cfg, versions.cfg (including its dependencies) and as dependency in setup.py.

Deliverables

Since we remove, there are just some PR's.

Risks

Installations using this package need to explicitly specify plone.app.openid. It will not go away. This need a line in the upgrade guide.

Participants

Jens Klein Johannes Raggam

see also plone/Products.CMFPlone#1554

tisto commented 8 years ago

+1

Von meinem iPhone gesendet

Am 30.06.2016 um 18:43 schrieb Jens W. Klein notifications@github.com:

Proposer : Jens Klein

Seconder : Johannes Raggam

Abstract

plone.app.openid is an old OpenID implementation for Plone used by very few users.

Motivation

It is rarely used and should live as an addon. Also knowdays there are better and more flexible implementation for OpenID supporting much more other protocols, like the more widespread OAuth2: pas.plugins.authomatic. We do not want to mainatin it anymore. It reduces the number of packages in Plone. Also we get rid of a warning while startup.

Assumptions

Nothing needs to happen before this PLIP.

Proposal & Implementation

Remove from sources.cfg, versions.cfg (including its dependencies) and as dependency in setup.py.

Deliverables

Since we remove, there are just some PR's.

Risks

Installations using this package need to explicitly specify plone.app.openid. It will not go away. This need a line in the upgrade guide.

Participants

Jens Klein Johannes Raggam

see also plone/Products.CMFPlone#1554

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jensens commented 8 years ago

@tisto: please vote also on the PLIP worksheet

tisto commented 8 years ago

Done

Am 05.07.16 um 21:33 schrieb Jens W. Klein:

@tisto https://github.com/tisto: please vote also on the PLIP worksheet

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/plone/Products.CMFPlone/issues/1659#issuecomment-230579072, or mute the thread https://github.com/notifications/unsubscribe/AAmlKWgmTt0dQfzdQByj78NGIMdvjh3Tks5qSrGRgaJpZM4JCWrC.

jensens commented 8 years ago

PLIP "implemented" ... ready for review :D

gforcada commented 8 years ago

Merged!

jensens commented 8 years ago

@gforcada :D intend was to let it go through the plip process, but since we have 6 of 7 votes positive and one abstention (non voted): I will not revert it. If anyone of @plone/framework-team feels different please do revert so we can stick to the full process.

gforcada commented 7 years ago

@jensens @thet buildout.coredev was not cleaned up, see https://github.com/plone/buildout.coredev/issues/353