search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Remove old translations #206

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Closes #205

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

Quite a few test failures, are those related?

gforcada commented 1 year ago

No idea, the robot tests failing are related to tests, so it might be indeed related 🤔

Let's try again 🍀

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

@davisagli seems that it was a commit done directly to master branch

We were not seeing that in jenkins as mr.roboto somehow did not add plone.app.discussion to checkouts.cfg 🤔

Not it should be all good, right Jenkins? 🤞🏾

@jenkins-plone-org please run jobs