search

plone / plone.app.theming

Integrates the Diazo theming engine with Plone
https://docs.plone.org/external/plone.app.theming/docs/index.html
Other
21 stars 30 forks source link

fix: if there is no rules.xml given, abort early #216

Closed jensens closed 1 year ago

jensens commented 1 year ago

Otherwise, given an open file is given as iterable, the read pointer is empty after this function, but None returned. This way the read pointer is not touched.

this supersedes https://github.com/collective/plonetheme.tokyo/pull/69 and fixes the real cause cc @santonelli

Thanks for pair-debugging this @toalba

mister-roboto commented 1 year ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 year ago

@jenkins-plone-org please run jobs