search

plone / plone.outputfilters

Provides a framework for registering filters that get applied to text as it is rendered.
6 stars 15 forks source link

Image caption support in Plone 5.1.x #38

Closed tuticapi closed 4 years ago

tuticapi commented 4 years ago

Merge with: https://github.com/plone/mockup/pull/978 https://github.com/plone/Products.CMFPlone/pull/3099 https://github.com/plone/plone.outputfilters/pull/38 https://github.com/plone/plone.app.upgrade/pull/232

mister-roboto commented 4 years ago

@tuticapi you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 4 years ago

@tuticapi thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mister-roboto commented 4 years ago

@tuticapi thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

tuticapi commented 4 years ago

@jenkins-plone-org please run jobs

tuticapi commented 4 years ago

@jenkins-plone-org please run jobs

thet commented 4 years ago

@tuticapi I started a new jenkins run with these 3 PRs together: https://github.com/plone/mockup/pull/978 https://github.com/plone/Products.CMFPlone/pull/3099 https://github.com/plone/plone.outputfilters/pull/38

I didn't include the https://github.com/plone/plone.app.upgrade/pull/232 because that would fail and is not necessary to check if all is still working on a fresh install.

This is the jenkins run: https://jenkins.plone.org/job/pull-request-5.1/304/

thet commented 4 years ago

Uhm. I recognized, I wanted to check with plone.outputfilter master :/

thet commented 4 years ago

OK, next try. I created a buildout.coredev branch for 5.1 which depends on plone.outputfilters master/4.0.1: https://github.com/plone/buildout.coredev/pull/658

Now a new Jenkins run with these PRs: https://github.com/plone/buildout.coredev/pull/658 https://github.com/plone/mockup/pull/978 https://github.com/plone/Products.CMFPlone/pull/3099

(Side note: technically the mockup checkout doesn't do much because the tests don't build a JS bundle.)

This is the Jenkins run: https://jenkins.plone.org/job/pull-request-5.1/305/

Let's see what happens.

thet commented 4 years ago

PR rejected. See: https://community.plone.org/t/image-captions-from-plone-5-1/12255/10