search

plone / plone.outputfilters

Provides a framework for registering filters that get applied to text as it is rendered.
6 stars 15 forks source link

Query registry once #64

Closed gotcha closed 1 year ago

gotcha commented 1 year ago

instead of querying it for each img tag.

mister-roboto commented 1 year ago

@gotcha thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gotcha commented 1 year ago

@MrTango Thx for the review. Am I supposed to merge myself ? What is the current best practice in Plone core repos ?

MrTango commented 1 year ago

it's a small change, feel free to merge it. I'm not at the desk right now. as long as the test are running should be fine.