Closed svx closed 6 years ago
@svx could you say something about urgency? I am extremely busy at the moment, and could try to shedule it for next Tuesday, will that be ok?
@loechel as workaround I removed the line:
LANGUAGES: {% if theme_doc_languages|length > 0 %}['{{ theme_doc_languages|join("', '", attribute='lang_code') }}']{% else %}[]{% endif %},
from the js template, since we are only using en this is working.
So for the moment that is OK, but we should fix that as soon as someone has time :)
I have looked into it, but could not reproduce it, any hints how to raise this error?
This was with papyrus branch 5.1
Sphinx = 1.6.7
I did not try with the latest Sphinx version, yet.
If you follow the steps in https://github.com/plone/papyrus/blob/5.1/docs/install.rst the error occurs by running make html
.
First it runs and after some time it stops with this error message.
@loechel @polyester We still have theme errors, this is with Sphinx 1.7.2
Theme error:
An error happened in rendering the page CHANGES.
Reason: TypeError("do_join() got an unexpected keyword argument 'attribute'",)
Makefile:67: recipe for target 'html-en' failed
make: *** [html-en] Error 2
Again fixed by removing:
LANGUAGES: {% if theme_doc_languages|length > 0 %}['{{ theme_doc_languages|join("', '", attribute='lang_code') }}']{% else %}[]{% endif %},
@svx OK I have traced it down. The Problem is not sphinxtheme.plone it are the version pins on papyrus, which pulled Jinja2 2.5.5 and not 2.10
I did fix that in https://github.com/plone/papyrus/commit/bdeba044ff7f7c4e5737cda1377b9bd9350848cb
Currently running
`make html
with papyrus gives the following error:@loechel maybe do you have time to have a look ?
Thanks !