plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
425 stars 576 forks source link

Accessibility tests in CMS-UI #4793

Open Wagner3UB opened 11 months ago

Wagner3UB commented 11 months ago

Initial tests inside Cypress for keyboard accessibility.

This is a minimal part of the hole and long process. So far, we have conducted a test to replicate the behavior of a user inside the CMS-UI after creating a new component "news item", where the user modifies a content and save it using only the keyboard. In this process, we had fixed some A11Y problems:

@sneridagh We want to know two things:

netlify[bot] commented 11 months ago

Deploy Preview for volto canceled.

Name Link
Latest commit 0f6523311fb30cfb6b3c9b5c69748bf4c443560c
Latest deploy log https://app.netlify.com/sites/volto/deploys/646794d2c8ccf2000808aa18
cypress[bot] commented 11 months ago

Passing run #5221 ↗︎

0 493 20 0 Flakiness 0

Details:

Merge branch 'master' into a11y-edit-accessibility-tests
Project: Volto Commit: 0f6523311f
Status: Passed Duration: 13:58 💡
Started: May 19, 2023 3:28 PM Ended: May 19, 2023 3:42 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

sneridagh commented 9 months ago

@Wagner3UB all good for me, go ahead with the current implementation.

If it's possible do not introduce changes in the formatting of the less files (take a look at the diffs) probably an IDE formatter run on them and introduced some formatting changes along with legit ones. It's better to group them all in the same PR (if any). Also, these ones were intended, so not much of value in this PR.

Thanks for taking care! Please continue and let me know the outcome and the status.