search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
425 stars 575 forks source link

SSR redirections #4821

Open mamico opened 10 months ago

mamico commented 10 months ago

this is an attempt to solve #4800 (the part "adjust SSR code to pass on the redirect that it gets from the api redirect") and #1095 issues

netlify[bot] commented 10 months ago

Deploy Preview for volto canceled.

Name Link
Latest commit 6b203a89a5e94ec7374c53d534ebe3191a766c29
Latest deploy log https://app.netlify.com/sites/volto/deploys/64a6d2368c7a0c0008fb70af
cypress[bot] commented 10 months ago

Passing run #6154 ↗︎

0 511 20 0 Flakiness 0

Details:

Merge branch 'master' into ssr_redirect
Project: Volto Commit: 6b203a89a5
Status: Passed Duration: 13:53 💡
Started: Jul 6, 2023 2:43 PM Ended: Jul 6, 2023 2:57 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

mamico commented 10 months ago

307 and 308 are also redirect statuses, and we should probably handle them.

Probably. But at the moment I am focused on GET/HEAD and 301/302 which, IMHO, cover most of the cases in question.