search

ploppyperson / StackMob-5

A plugin for bukkit servers, which aims to reduce the lag that the server experiences by combining several entities into a single entity.
GNU General Public License v3.0
55 stars 21 forks source link

Named bees stacking in certain scenarios (hive confliction) #264

Open andrewkm opened 2 years ago

andrewkm commented 2 years ago

Bug: https://ecocitycraft.com/forum/threads/.219236/ Quote: After some testing at both Zulu's bees and my own. I went to the bees, named them and they unstack and remain unstacked, BUT once they enter the hives and exit again they do eventually stack. I tested this on a fresh swarm of bees on my own, from hives and spawn eggs. The name-tags are working correctly, it looks like the issue here is the bee's entering the hive seems to change them/render the name useless and they stack eventually after exiting.

StackMob one commit behind, compiled against: https://github.com/Nathat23/StackMob-5/commit/e5b74af5308928a8135ff1d97d4dc6bf1d236b66 Paper 1.19.2 Build 263 StackMob config: https://pastebin.com/fkKaEQFz

andrewkm commented 1 year ago

Any ideas what I can do here @Nathat23

Aurelien30000 commented 1 year ago

Hello! A released bee seems considered as a new spawned entity, so stack logic is re-applied. We may have to add a specific BEEHIVE spawn reason check. For now, as a workaround, you can add this spawn reason to the blacklist or use and cancel StackSpawnEvent when needed, if it's really annoying for your server.

andrewkm commented 1 year ago

Thank @Aurelien30000 :) I will wait for you guys to add the BEEHIVE spawn reason, which would help a lot!

andrewkm commented 1 year ago

Any updates on potentially implementing a fix here?

ploppyperson commented 1 year ago

I have added a permanent fix.

andrewkm commented 1 year ago

Thanks! Confirmed working :)

andrewkm commented 2 months ago

We've just got a report from the original player @ploppyperson that this is for some reason once again broken. New report: https://ecocitycraft.com/forum/threads/s.225957/ Old report can be seen here: https://ecocitycraft.com/forum/threads/.219236/

After your initial permanent fix, everything seemed good once again and we removed the workaround of adding BEEHIVE spawn reason to the blacklist. However, now, out of the blue it is broken. I suspect Mojang changes have something to do with it. :(

Our config currently looks as such: https://pastebin.com/sCNErbpR

andrewkm commented 2 months ago

It looks like going back to the workaround (adding BEEHIVE spawn reason to the blacklist) works as a temporary solution once more.

Aurelien30000 commented 2 months ago

Hey! Thanks for opening the report again. At first glance, it may be a minor commit overwrite problem.

@ploppyperson In the history, the fix has been "erased" since the merge of 11/08/2023: https://github.com/ploppyperson/StackMob-5/commits/master/src/main/java/uk/antiperson/stackmob/listeners/SpawnListener.java