alexcjohnson
commented
3 years ago Thanks @Karan-S-Mittal - the code changes look promising, I'll review those shortly, but something odd happened with the build process: the quote characters in the build:r package script were treated as part of the input, so we ended up with a bunch of duplicate files like R/'daq'Gauge.R in addition to the expected R/daqGauge.R, and man/'daq'Gauge.Rd in addition to man/daqGauge.Rd. Also in the new .Rd files there are a whole lot of ^M characters (CR) - not at all line breaks, but at many of them, and occasionally not at a line break at all, like here.
I'm assuming these are all a result of running the same commands we've used in the past, but you're on Windows and most of the rest of us develop on Mac or Linux. In a sense this is good, an opportunity for us: it should work fine to build components on Windows, we just need to figure out why it didn't.
The good news is building the Python components seems to have worked perfectly. There are changes in these files, but that's to be expected because we've updated the Python component generator since dash-daq was most recently rebuilt.
So the two routes we could take are:
- Figure out a way to run on Windows with the existing code, and document this
- Fix the code so it works correctly on Windows whichever way you run it.
The latter is preferable if you're up for it. The place this is all happening is https://github.com/plotly/dash/blob/dev/dash/development/_r_components_generation.py. Re: CR, if we're loading the source files correctly Python should have already converted \r\n to \n for us, but perhaps we need to explicitly replace os.linesep with \n in some cases? And re: the single quotes, maybe we want to solve this up a level? In principle all the args here should have quotes removed if any made it that far.
Karan-S-Mittal
These are the issues, I worked on
https://github.com/plotly/dash-daq/issues/123 Before:
After:
https://github.com/plotly/dash-daq/issues/125 The issue was that when the color range's last value was different from the max value of gauge, this was leading to default colored gauge. Added a function convertInRange in which will handle the color values of Gauge and equalise the values provided in color range with max value of gauge.
Before:
After:
yarn demotonpm run dash-demoThis issue was related to documentation and mismatch between package.json commands. the contributing section of daq needed updation. I have changed the commands fromyarntonpmas that proved for me to be less error-prone and all the commands were using npm. Please have a look at contributing section and documentation.Thank you so much for reviewing.