plotly / dash-daq

Control components for Dash
MIT License
141 stars 40 forks source link

Visual bugs found in DDK Docs for DAQ #153

Open luiztauffer opened 3 years ago

luiztauffer commented 3 years ago

Some visual bugs that should still be fixed (@vinicvaz)

Karan-S-Mittal commented 3 years ago

Solution Preview:

issue 153

Code:

app.layout = html.Div(
    [
            html.Div(
                [html.H2("Switch Issue 153", className="text-center")], className="row"
            ),
            html.Div(
                daq.BooleanSwitch(
                    id="my-switch-1", on=True, label="Vertical", vertical=True
                ),
                className="row",
            ),
            html.Div(
                [html.H2("Slider Issue 153", className="text-center")], className="row"
            ),
            html.Div(daq.Slider(vertical=True), className="row"),
            html.Div(
                [html.H2("Slider Issue Dark mode 153", className="text-center")],
                className="row",
            ),
            html.Div(
                daq.DarkThemeProvider(daq.Slider(vertical=True), theme={"dark": True}),
                className="row",
            ),
            html.Div(
                [
                    html.H2(
                        "LED Display Backgroun for darkmode Issue 153",
                        className="text-center",
                    )
                ],
                className="row",
            ),
            html.Div(
                daq.DarkThemeProvider(
                    daq.LEDDisplay(
                        value="3.14159",
                    ),
                    theme={"dark": True},
                ),
                className="row",
            ),
    ]
)
luiztauffer commented 3 years ago

hey @Karan-S-Mittal , that looks good! But this is not being controlled by DDK, instead it is being defined by daq.DarkThemeProvider, right? What we would like it for DDK to change those color properties, from slider and LEDDisplay

Karan-S-Mittal commented 3 years ago

ok, I will make a example with that and see if it doesn't give any bugs.