Please @ mention a few other speakers of this language who can help review your translations.
If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
You should only update files in lib/locales/, not those in dist/
Features, Bug fixes, and others:
Before opening a pull request, developer should:
make sure they are not on the master branch of their fork as using master for a pull request would make it difficult to fetch upstream changes.
fetch latest changes from upstream/master into your fork i.e. origin/master then pull origin/master from you local master.
then git rebase master their local dev branch off the latest master which should be sync with upstream/master at this time.
make sure to notgit add the dist/ folder (the dist/ is updated only on version bumps).
make sure to commit changes to the package-lock.json file (if any new dependency required).
provide a title and write an overview of what the PR attempts to do with a link to the issue they are trying to address.
select the Allow edits from maintainers option (see this article for more details).
After opening a pull request, developer:
should create a new small markdown log file using the PR number e.g. 1010_fix.md or 1010_add.md inside draftlogs folder as described in this README, commit it and push.
should not force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetch upstream/master and "merge" with master instead of "rebase".
Thanks for your interest in plotly.js!
Translations:
lib/locales/, not those indist/Features, Bug fixes, and others:
Before opening a pull request, developer should:
masterbranch of their fork as usingmasterfor a pull request would make it difficult to fetchupstreamchanges.upstream/masterinto your fork i.e.origin/masterthen pullorigin/masterfrom you localmaster.git rebase mastertheir local dev branch off the latestmasterwhich should be sync withupstream/masterat this time.git addthedist/folder (thedist/is updated only on version bumps).package-lock.jsonfile (if any new dependency required).After opening a pull request, developer:
1010_fix.mdor1010_add.mdinsidedraftlogsfolder as described in this README, commit it and push.git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetchupstream/masterand "merge" with master instead of "rebase".