pluginpal / strapi-plugin-sitemap

🔌 Generate a highly customizable sitemap XML in Strapi CMS
https://www.pluginpal.io/plugin/sitemap
MIT License
252 stars 53 forks source link

Allow core.js customisation #166

Closed ilnytskyi closed 7 months ago

ilnytskyi commented 8 months ago

Call methods via service

What does it do?

Call methods in core.js via service

Why is it needed?

Allows more flexible customization https://github.com/pluginpal/strapi-plugin-sitemap/issues/60

How to test it?

Try override one of the methods from core.js inside your extensions/sitemap/strapi-server.ts customization as described in https://github.com/pluginpal/strapi-plugin-sitemap/issues/60

Related issue(s)/PR(s)

https://github.com/pluginpal/strapi-plugin-sitemap/issues/60

boazpoolman commented 8 months ago

Hi @ilnytskyi Thanks for this PR, seems like a nice addition.

Could you fix the eslint issue that's happening? You probably just need to export the getDefaultLanguageLink function and then it can get merged :)