search

pluginsGLPI / formcreator

GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)
http://www.teclib-edition.com
GNU General Public License v3.0
174 stars 125 forks source link

fix: adjust dashboard widget height #3490

Closed ccailly closed 2 months ago

ccailly commented 7 months ago

Changes description

Checklist

Please check if your PR fulfills the following specifications:

References

Closes #N/A

Correct dashboard widget height in install.php. Previous pull request, #3306 refactored UI of widgets but missed updating install.php. A subsequent commit updated install.php but set widget height to 1 instead of the correct value 2.

This PR fixes the widget height value to 2.

ccailly commented 7 months ago

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update. It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

btry commented 7 months ago

Hi

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update. It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

Actually, the plugin takes measures to prevent users to modify its mini dashboard. Noone should be able to modify it (neither super-admins). This is why it should be safe to modify it programmatically