search

plurals / pluralize

Pluralize or singularize any word based on a count
MIT License
2.12k stars 178 forks source link

Add preserveCasing option to addIrregularRule #193

Open huanvu opened 2 years ago

huanvu commented 2 years ago

Added a preserveCasing option to addIrregularRule to handle cases where you want to pluralize things like ID => IDs.

huanvu commented 1 year ago

Sorry, totally forgot to follow up, made changes to address your comments

pixelpax commented 7 months ago

@blakeembrey could this be merged? It's the only thing preventing my team from using Pluralize in place of an in-house solution. I imagine it's a blocker for many other teams since this is a really common need for anyone using acronyms

e.g. "ID" -> "IDs" instead of "IDS" or "SSN"->"SSNs"

pixelpax commented 5 months ago

@blakeembrey This repo is full of stale PRs that have been waiting for years. I feel that it's inappropriate to accept sponsorship for this repo if you're not going to invest the time to review and accept contributions. Others have offered to help you maintain it in other threads.

I totally get that you produced and maintained this on a voluntary basis and I'm sure you have other, much higher priority tasks in your life. I'm grateful to you for making it and recognize it may not be a responsibility you asked for.

However, there are currently 8 million downloads a week and many, many projects which depend on this library. I believe the responsible thing to do would be to deputize some of the other contributors who have offered to help maintain it, or commit to allocating time to weekly maintenance.

blakeembrey commented 5 months ago

@pixelpax unfortunately this isn’t a great place to have this discussion. While I understand your point of view, I think you seriously underestimate the amount I earn from sponsorships of this package. If you think money = work, I am making enough to do 30 seconds/month on this repo. We’re talking $1 or so. That’s a depressing way to look at.

This is not a job. This is something I try to do when I have time. Nothing is massively broken. I will work on reviewing the issues when I have time.

Even just this PR would take up to an hour, so maybe I can save up in your concept of being paid to do work?

Please please don’t try to make other maintainers feel guilty because they earn $1/month from software they wrote. That feeling is why I stopped working on Open Source. I always felt guilty. I’ve only just gotten over that feeling. Just some context from my side.