The tj-actions/verify-changed-files action allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.
Details
The verify-changed-files workflow returns the list of files changed within a workflow execution.
This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.
Proof of Concept
Submit a pull request to the repository with a new file injecting a command. For example $(whoami).txt would be a valid filename.
Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files tracked and untracked files step.
- name: List all changed files tracked and untracked files
run: |
echo "Changed files: $"
This issue may lead to arbitrary command execution in the GitHub Runner.
Resolution
A new safe_output input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.
A safe recommendation of using environment variables to store unsafe outputs.
- name: List all changed files tracked and untracked files
env:
CHANGED_FILES: $
run: |
echo "Changed files: $CHANGED_FILES"
tj-actions/verify-changed-files (tj-actions/verify-changed-files)
### [`v15`](https://togithub.com/tj-actions/verify-changed-files/releases/tag/v15)
[Compare Source](https://togithub.com/tj-actions/verify-changed-files/compare/v14...v15)
### Changes in v15.0.2
#### What's Changed
- Upgraded to v15.0.1 by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/308](https://togithub.com/tj-actions/verify-changed-files/pull/308)
- Bump peter-evans/create-pull-request from 5.0.1 to 5.0.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/verify-changed-files/pull/309](https://togithub.com/tj-actions/verify-changed-files/pull/309)
- chore(deps): update reviewdog/action-shellcheck action to v1.18 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/311](https://togithub.com/tj-actions/verify-changed-files/pull/311)
**Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v15...v15.0.2
***
### Changes in v15.0.1
#### What's Changed
- Upgraded to v15 by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/305](https://togithub.com/tj-actions/verify-changed-files/pull/305)
- chore(deps): update tj-actions/verify-changed-files action to v15 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/306](https://togithub.com/tj-actions/verify-changed-files/pull/306)
- Updated README.md by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/307](https://togithub.com/tj-actions/verify-changed-files/pull/307)
**Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v15...v15.0.1
***
### Changes in v15.0.0
### 🔥 🔥 Breaking Changes 🔥 🔥
- `match-gitignore-files` input introduced and enabled by default which would include git ignored files generated during the workflow execution.
#### What's Changed
- Upgraded to v14.0.2 by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/290](https://togithub.com/tj-actions/verify-changed-files/pull/290)
- chore(deps): update tj-actions/auto-doc action to v2.4.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/292](https://togithub.com/tj-actions/verify-changed-files/pull/292)
- Updated README.md by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/293](https://togithub.com/tj-actions/verify-changed-files/pull/293)
- Bump peter-evans/create-pull-request from 5.0.0 to 5.0.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/verify-changed-files/pull/294](https://togithub.com/tj-actions/verify-changed-files/pull/294)
- chore(deps): update tj-actions/auto-doc action to v2.5.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/295](https://togithub.com/tj-actions/verify-changed-files/pull/295)
- chore(deps): update tj-actions/auto-doc action to v2.5.2 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/296](https://togithub.com/tj-actions/verify-changed-files/pull/296)
- chore(deps): update tj-actions/auto-doc action to v2.5.4 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/297](https://togithub.com/tj-actions/verify-changed-files/pull/297)
- Updated README.md by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/298](https://togithub.com/tj-actions/verify-changed-files/pull/298)
- chore(deps): update tj-actions/auto-doc action to v2.6.1 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/299](https://togithub.com/tj-actions/verify-changed-files/pull/299)
- chore(deps): update tj-actions/auto-doc action to v2.7.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/301](https://togithub.com/tj-actions/verify-changed-files/pull/301)
- chore(deps): update actions/checkout action to v3.5.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/302](https://togithub.com/tj-actions/verify-changed-files/pull/302)
- feat: add support for including git ignored files. by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/303](https://togithub.com/tj-actions/verify-changed-files/pull/303)
- Updated README.md by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/304](https://togithub.com/tj-actions/verify-changed-files/pull/304)
#### New Contributors
- [@tj-actions-bot](https://togithub.com/tj-actions-bot) made their first contribution in [https://github.com/tj-actions/verify-changed-files/pull/304](https://togithub.com/tj-actions/verify-changed-files/pull/304)
**Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v14...v15.0.0
***
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
[ ] If you want to rebase/retry this PR, check this box
This PR contains the following updates:
v14
->v15
GitHub Vulnerability Alerts
CVE-2023-52137
Summary
The
tj-actions/verify-changed-files
action allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.Details
The
verify-changed-files
workflow returns the list of files changed within a workflow execution.This could potentially allow filenames that contain special characters such as
;
and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside arun
block. By running custom commands an attacker may be able to steal secrets such asGITHUB_TOKEN
if triggered on other events thanpull_request
. For example onpush
.Proof of Concept
$(whoami).txt
would be a valid filename.List all changed files tracked and untracked files
step.Example output:
Impact
This issue may lead to arbitrary command execution in the GitHub Runner.
Resolution
A new
safe_output
input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.A safe recommendation of using environment variables to store unsafe outputs.
Resources
Release Notes
tj-actions/verify-changed-files (tj-actions/verify-changed-files)
### [`v15`](https://togithub.com/tj-actions/verify-changed-files/releases/tag/v15) [Compare Source](https://togithub.com/tj-actions/verify-changed-files/compare/v14...v15) ### Changes in v15.0.2 #### What's Changed - Upgraded to v15.0.1 by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/308](https://togithub.com/tj-actions/verify-changed-files/pull/308) - Bump peter-evans/create-pull-request from 5.0.1 to 5.0.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/verify-changed-files/pull/309](https://togithub.com/tj-actions/verify-changed-files/pull/309) - chore(deps): update reviewdog/action-shellcheck action to v1.18 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/311](https://togithub.com/tj-actions/verify-changed-files/pull/311) **Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v15...v15.0.2 *** ### Changes in v15.0.1 #### What's Changed - Upgraded to v15 by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/305](https://togithub.com/tj-actions/verify-changed-files/pull/305) - chore(deps): update tj-actions/verify-changed-files action to v15 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/306](https://togithub.com/tj-actions/verify-changed-files/pull/306) - Updated README.md by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/307](https://togithub.com/tj-actions/verify-changed-files/pull/307) **Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v15...v15.0.1 *** ### Changes in v15.0.0 ### 🔥 🔥 Breaking Changes 🔥 🔥 - `match-gitignore-files` input introduced and enabled by default which would include git ignored files generated during the workflow execution. #### What's Changed - Upgraded to v14.0.2 by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/290](https://togithub.com/tj-actions/verify-changed-files/pull/290) - chore(deps): update tj-actions/auto-doc action to v2.4.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/292](https://togithub.com/tj-actions/verify-changed-files/pull/292) - Updated README.md by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/293](https://togithub.com/tj-actions/verify-changed-files/pull/293) - Bump peter-evans/create-pull-request from 5.0.0 to 5.0.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/tj-actions/verify-changed-files/pull/294](https://togithub.com/tj-actions/verify-changed-files/pull/294) - chore(deps): update tj-actions/auto-doc action to v2.5.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/295](https://togithub.com/tj-actions/verify-changed-files/pull/295) - chore(deps): update tj-actions/auto-doc action to v2.5.2 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/296](https://togithub.com/tj-actions/verify-changed-files/pull/296) - chore(deps): update tj-actions/auto-doc action to v2.5.4 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/297](https://togithub.com/tj-actions/verify-changed-files/pull/297) - Updated README.md by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/298](https://togithub.com/tj-actions/verify-changed-files/pull/298) - chore(deps): update tj-actions/auto-doc action to v2.6.1 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/299](https://togithub.com/tj-actions/verify-changed-files/pull/299) - chore(deps): update tj-actions/auto-doc action to v2.7.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/301](https://togithub.com/tj-actions/verify-changed-files/pull/301) - chore(deps): update actions/checkout action to v3.5.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/302](https://togithub.com/tj-actions/verify-changed-files/pull/302) - feat: add support for including git ignored files. by [@jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/303](https://togithub.com/tj-actions/verify-changed-files/pull/303) - Updated README.md by [@tj-actions-bot](https://togithub.com/tj-actions-bot) in [https://github.com/tj-actions/verify-changed-files/pull/304](https://togithub.com/tj-actions/verify-changed-files/pull/304) #### New Contributors - [@tj-actions-bot](https://togithub.com/tj-actions-bot) made their first contribution in [https://github.com/tj-actions/verify-changed-files/pull/304](https://togithub.com/tj-actions/verify-changed-files/pull/304) **Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v14...v15.0.0 ***Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.