question: should we start padding inputs with `256` or `-1` instead of `0`?

pluto / web-prover-circuits

Circuits for Pluto's `web-prover`

Apache License 2.0

12 stars 0 forks source link

question: should we start padding inputs with `256` or `-1` instead of `0`? #60

Open Autoparallel opened 6 days ago

Autoparallel commented 6 days ago

The reason why is that a byte is a value 0-255. Using 0 makes this a bit ambiguous. Perhaps we should make it abundantly clear by choosing either 256 or -1.

-1 is a bit simpler to see/write when creating witness functions in Rust. My slight preference would be for that.

Autoparallel commented 6 days ago

This is just a footgun waiting to happen -- changes priority to high.