Spectator mode weird behavior when going through blocks

NickteeChunky commented 1 year ago

Issue description

Expected result: to be able to move through blocks in spectator mode
Actual result: every time my head hits a block in spectator mode, my flight resets (sometimes) and it moves me downwards slightly. it's very cursed behavior so watch the video below

Steps to reproduce the issue

execute /gamemode spectator
move through a block

OS and versions

PocketMine-MP: 4.20.0
PHP: 8.0.13
Using JIT: no
Server OS: windows & linux
Game version: Win10

holding jump is what causes it to keep repeating https://streamable.com/gsrs4p

dktapps commented 1 year ago

Looks like the client-side "push out of blocks" physics is kicking in when it shouldn't. Not sure why it would be doing that though.

dadodasyra commented 1 year ago

It seems that the blockCollision ability still works though. Just someone told me you lose the flight state when going upward with it, don't know if it's related.

dktapps commented 1 year ago

Yeah, I haven't been able to figure out why it's behaving this way. If anyone finds a way to fix it, please let me know or send a PR.

MINTEDCLICKS commented 1 year ago

i am also suffering from this issue

pmmp / PocketMine-MP