Fixed rotation defect in VRMLLoader.js

pmndrs / three-stdlib

📚 Stand-alone library of threejs examples designed to run without transpilation in node & browser

https://npmjs.com/three-stdlib

MIT License

704 stars 117 forks source link

Fixed rotation defect in VRMLLoader.js #355

Closed vorth closed 5 months ago

vorth commented 5 months ago

Why

Three.js AxisAngle apparently requires a normalized axis vector. VRML may also, but I had many files (converted from VRML 1.0) that contained un-normalized axis vectors.

Whether there is a defect in my VRML data or not, normalization is idempotent and can only help.

What

I added .normalize() to the axis vector for a rotation in VRMLLoader.js.

Checklist

[ ] Documentation updated
[ ] Storybook entry added
[x] Ready to be merged

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 2.29.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: