search

pmusolino / PMAlertController

PMAlertController is a great and customizable alert that can substitute UIAlertController
MIT License
2.53k stars 186 forks source link

Added Custom Padding on Alert Description StackView #60

Closed mdflores closed 6 years ago

mdflores commented 6 years ago

Alert Description is too close to the AlertController's ContentView when Alert Description is customized not to have a center alignment.

Changes for this PR: Added Custom Padding on Alert Description StackView Updated Sample Project

pasevin commented 6 years ago

Great addition to customization.

pmusolino commented 6 years ago

Thanks for this PR, I check it out during the weekend.

pmusolino commented 6 years ago

@mdflores I reviewed your PR, but there are some problems.

First of all, the name for the two constraints is ambiguous, because inside the alert there are two UIStackViews, one for title and description, and one for the buttons (PMAlertAction). You named the constraints alertStackViewLeadingConstraint and alertStackViewTrailingConstraint but there is another constraint called alertStackViewHeightConstraint that is a reference to the 2° stack view. Then, try to find a name to disambiguate.

The second point: you implemented this feature, but is interesting to implement the same on the second stack view (alertActionStackView).

Please, integrate this and I can approve your PR. Thanks

-Paolo

pasevin commented 6 years ago

I've expanded on this pull request and addressed your comments @pmusolino https://github.com/pmusolino/PMAlertController/pull/61

pmusolino commented 6 years ago

Closed in favor of https://github.com/pmusolino/PMAlertController/pull/61