pnp / generator-teams

A Yeoman Generator for Microsoft Teams
https://pnp.github.io/generator-teams
MIT License
415 stars 110 forks source link

Bug report: gulp manifest doesn't generate manifest (or errors) #343

Open pglombardo opened 1 year ago

pglombardo commented 1 year ago

Description

gulp manifest doesn't generate a manifest zip file.

Steps to reproduce

gulp manifest

Expected results

Screenshot 2022-12-11 at 12 49 57

Actual results

Screenshot 2022-12-11 at 12 48 59

Project you experience issues with

yoteams-deploy

generator version

4.0.1

build tools version

1.8.0

nodejs version

v16.13.2

npm version

8.1.2

Operating system (environment)

macOS

Additional Info

It was working at one point, returned today and the pre-existing manifest zipfile wasn't being updated. Unzip & validate the manifest - not updated. Just delete the zipfile. gulp manifest never recreates the file and no error in command.

yoteams-deploy version is 1.2.0-preview.2

gulp nuke, gulp build, gulp validate-manifest and gulp manifest all execute without error but still no manifest zip file.

pglombardo commented 1 year ago

The manifest.json file had a syntax error in it:

Screenshot 2022-12-11 at 13 04 56

I commented out a line and didn't think about it. Removed that line entirely and now manifests are being generated.

So I guess the question is: why did gulp [validate-manifest|manifest|build] pass without errors?

RickVanRousselt commented 1 year ago

Hi @pglombardo

That's indeed not good. Thanks very much for reporting. We need to do some investigation then.

Cheers,