search

pnp / graph-connectors-samples

Microsoft Graph Connector samples
https://aka.ms/gc/samples
MIT License
48 stars 35 forks source link

Diagrams and Dark Mode #25

Closed pkbullock closed 1 year ago

pkbullock commented 1 year ago

Hi @waldekmastykarz ,

In the sample: https://github.com/pnp/graph-connectors-samples/tree/main/samples/nodejs-typescript-food-catalog reading through the samples and noticed in some cases the diagrams do not represent well in dark mode on GH.

Its only some of them, those with swim lanes seem fine:

image

Albeit this is a very cool sample, with the explanations and learnings around the multiple ingestion scenarios - GREAT WORK!! Both of you @garrytrinder and @waldekmastykarz

garrytrinder commented 1 year ago

Thanks for letting us know @pkbullock

Unfortunately, I'm not sure if there is much we can do about this, the C4 model is currently experimental and I guess lacks support for different themes at this time. However, we should keep this in mind and maybe add a remark on the page about viewing these diagrams using dark mode. What do you think @waldekmastykarz ?

Thank you for your kind words ❤️

waldekmastykarz commented 1 year ago

Thank you for the kinds words @pkbullock! I think that's a great feedback for GitHub folks. Let us see if I we can find the right folks internally to get it fixed for everybody. I appreciate you letting us know ❤️

waldekmastykarz commented 1 year ago

Closing for now, as there's nothing that we can do about it on our end. But will update if we hear anything. Thanks again!