pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.05k stars 3.86k forks source link

Upgrade Calendar Feed web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event #5239

Open Adam-it opened 1 month ago

Adam-it commented 1 month ago

🎯Aim

The aim of this issue is to upgrade the Calendar Feed web part sample to the latest version of SPFx (1.20)

🤔 Tips how to get started

To support you in this issue you may use the below tooling:

📣 What's this event all about

Refresh Rangers is a unique Hacktoberfest event aiming to update our most popular samples 🚀. During this, you may obtain a unique Microsoft 365 & Power Platform Community badge - Refresh Rangers 🎖️ To obtain this badge besides opening a PR you also need to opt-in the Microsoft 365 & Power Platform Community Recognition Program and fill out this form

petkir commented 4 weeks ago

i'll take it @Adam-it

Adam-it commented 4 weeks ago

i'll take it @Adam-it

all yours 👏👏👏👏

Adam-it commented 6 days ago

@petkir what is the status on this one? The event is ending with October and this will mean that this won't count toward the Hacktoberfest event if you participated in this one (here there is nothing we may do about it) BUT a PR for this issue will be created even after October this will still count to get the Refresh Ranger badge from the Microsoft 365 and Power Platform Community

petkir commented 6 days ago

@Adam-itit's coming only Outlook feed is missing the other 3 providers work already. give me some time for the PR

petkir commented 2 days ago

Hi @Adam-it

Currently, the following providers are implemented:

Problem Description:

Originally, to avoid CORS problems, a proxy provider was used, but it returns Access-Control-Allow-Origin: *. This does not accapt my Edge Browser on a SharePoint Page. When I set the fetch mode to mode:'no-cors', I receive a successful response of type response.type === 'opaque'. While this allows me to download the data to the client, but I'm unable to manipulate the data using JavaScript.

I have experimented with other proxy providers and various Edge plugins, but none have proven to be effective solutions.

One potential solution I see is starting a web browser on localhost to make the request. However, there are no existing examples in this sample gallery that include an additional Azure function or something else.

on the other hand removing support for the Exchange Calendar Feed is also a solution, as it is referred to as the Exchange Public Calendar so ...

So what do you think @Adam-it : self-hosted proxy or remove the Exchange iCal support?

after playing hours i would remove the support for EX, because this is a thing of minutes.