search

pnwairfire / bluesky

BlueSky Framework rearchitected as a pipeable collection of standalone modules.
GNU General Public License v3.0
19 stars 11 forks source link

Tobias' last changes #266

Closed rschigas closed 1 year ago

rschigas commented 1 year ago

Growth bug (timezones), pull request 11, restore UBC growth module after AirFire merge.

rschigas commented 1 year ago

Joel, please cancel/disregard. I'm trying to do some updates, and used the wrong approach. Thx - R.

rschigas commented 1 year ago

Actually, if you have a chance maybe you can check something ... I'm trying to merge a bunch of your commits into our fork, and there's a conflict with these commits Tobias made. I've read through the growth and persistence modules and it appears to me that you've advanced them beyond what Tobias did.

Do you think I can discard these 4 commits in order to merge your updates? Thanks!

jdubowy commented 1 year ago

I think it's safe to discard these 4 commits. Tobias' code does have logic that mine doesn't related to removing fires that won't contribute to dispersion (method _remove_unused_fires), but that can be accomplished with the time window filter.

rschigas commented 1 year ago

OK! Thanks Joel - R.