po-devs / po-web

Pokemon Online webclient
11 stars 18 forks source link

update packages, clean up the build and server files, add eslint #186

Closed sulcata closed 8 years ago

sulcata commented 8 years ago

https://github.com/po-devs/po-web/pull/183 without linting the main js files

sulcata commented 8 years ago

Also feedback as to which eslint rules we should enable, disable, and alter would be nice. Pretty much anything and everything can be changed http://eslint.org/docs/rules/

coyotte508 commented 8 years ago

I was wrong in my previous remarks. Reindenting everything while you're making a change makes it hard to know what actually changed and judge whether or not to validate the PR.

You can edit po-server-scripts with eslint all you want, but - at the risk of sounding refractory, annoying, stubborn and so on - please not here.