search

poanetwork / hbbft

An implementation of the paper "Honey Badger of BFT Protocols" in Rust. This is a modular library of consensus.
Other
357 stars 96 forks source link

Reorganize DHB and HB builders. #333

Open afck opened 6 years ago

afck commented 6 years ago

There is a lot of duplication between HB, DHB and their builders. They each have an encryption_schedule, subset_handling_strategy, max_future_epochs, rng and, with #332, random_value.

We need to find a solution that avoids the duplication but still makes usage of the builders convenient. (E.g. maybe the above fields—probably excluding rng—should be grouped in a Params struct?)

afck commented 6 years ago

Unassigning this for now, but possibly the builders' individual setters should be removed, and the user should create a Params instead?