(Improvement) Update truffle version and solidity version - Githubissues

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network

https://popa.poa.network

GNU General Public License v3.0

24 stars 18 forks source link

(Improvement) Update truffle version and solidity version #192

Open phahulin opened 6 years ago

phahulin commented 6 years ago

What is it? (leave one option)
- (Improvement) proposal (i.e. some existing feature can be improved)

Next version of truffle brings upgrade of solidity compiler that also requires updates (errors and warnings) to the contracts code, most notably

use emit before events
keccak256 does not accepts multiple arguments. abi.encodePacked should be used
use of function with the same name as the contract is deprecated, new constructor should be used

This update also seem to break tests related to library PhysicalAddressClaim