podlove / podlove-publisher

Podlove Podcast Publisher for WordPress
https://wordpress.org/plugins/podlove-podcasting-plugin-for-wordpress/
MIT License
296 stars 82 forks source link

Wrong / double escaping of podcast titles #1495

Open poschi3 opened 2 weeks ago

poschi3 commented 2 weeks ago

Expected behavior

If I add a podcast and set a big title with a & I get it double escaped in some places (e.g. podcast title, player, feed): grafik grafik grafik

Actual behavior

Right escaping on every location

grafik

More information

I also have strange behavior I'm not able to explain. If I change a title after initial set it gets sometimes copied to other locations or on rendering is taken from different? I made a short video to show what the strange behavior is:

podlove-amp.webm

System information (see Podlove > Support menu)

I tested it local in docker and on my production instnace Local:

Website                    http://localhost
PHP Version                8.2.22
WordPress Version          6.6.1
WordPress Theme            Twenty Twenty-Four v1.2
Active Plugins             
           - Podlove Podcast Publisher v4.1.14
           - Podlove Web Player v5.8.0
WordPress Database Charset utf8
WordPress Database Collate 
Publisher Version          4.1.14
Publisher Database Version 157
Web Player Version         player_v5
open_basedir               ok
curl Version               7.88.1
iconv                      available
simplexml                  ok
max_execution_time         30
upload_max_filesize        2M
memory_limit               256M
disable_classes            
disable_functions          
permalinks                 "Häßliche" Permalinks: Bitte ändere die Permalinkstruktur
podlove_permalinks         ok
podcast_settings           ok
web_player                 ok
podlove_cache              on
assets                     
  - mp3    audio/mpeg       http://localhost/?feed=mp3
cron                       ok
duplicate_guids            ok

1 FEHLER: 
- Du verwendest die Standard-Permalink-Struktur von WordPress. Das könnte einigen Podcast-Clients Schwierigkeiten bereiten. Gehe zu http://localhost/wp-admin/options-permalink.php und setze die Einstellung auf etwas anderes als die Standardeinstellung (z.B. auf "Beitragsname")
0 notices

Production:

Website                    https://podcast.entbehrlich.es
PHP Version                8.1.29
WordPress Version          6.6.1
WordPress Theme            Marianne v1.8
Active Plugins             
           - Akismet Anti-spam: Spam Protection v5.3.3
           - Mastodon Autopost v3.7
           - XML Sitemap Generator for Google v4.1.21
           - Podlove Podcast Publisher v4.1.14
           - Podlove Web Player v5.8.0
           - WP-Telegram v4.1.13
WordPress Database Charset utf8mb4
WordPress Database Collate 
Publisher Version          4.1.14
Publisher Database Version 157
Web Player Version         player_v5
open_basedir               ok
curl Version               7.68.0
iconv                      available
simplexml                  ok
max_execution_time         60
upload_max_filesize        384M
memory_limit               384M
disable_classes            
disable_functions          
permalinks                 ok (/%year%/%monthnum%/%day%/%postname%/)
podlove_permalinks         ok
podcast_settings           ok
web_player                 ok
podlove_cache              on
assets                     
  - mp3    audio/mpeg       https://podcast.entbehrlich.es/feed/mp3/
  - opus   audio/ogg;codecs=opushttps://podcast.entbehrlich.es/feed/opus/
  - m4a    audio/mp4        https://podcast.entbehrlich.es/feed/m4a/
cron                       ok
duplicate_guids            ok

0 errors
0 notices
Nice, Everything looks fine!
eteubert commented 2 weeks ago

It's the Gutenberg editor. I have the beginnings of a fix in the linked PR but it needs more work. Until then, if you use the editor in "code" mode, that seems to help. Maybe that's a temporary workaround for you.

eteubert commented 2 weeks ago

I'm confident now that it's a bug in WordPress (see https://github.com/WordPress/gutenberg/issues/20490) and I'm not sure I can or should fix it on the Publisher side. Because it may break again if WordPress fixes the bug eventually. However the timeline is unclear because the bug exists since early 2020 🤷‍♂️