`QuickPickInput.svelte` and `CommandPalette.svelte` should have same design

podman-desktop / podman-desktop

Podman Desktop is the best free and open source tool to work with Containers and Kubernetes for developers. Get an intuitive and user-friendly interface to effortlessly build, manage, and deploy containers and Kubernetes — all from your desktop.

https://podman-desktop.io

Apache License 2.0

4.92k stars 312 forks source link

`QuickPickInput.svelte` and `CommandPalette.svelte` should have same design #7178

Open axel7083 opened 6 months ago

axel7083 commented 6 months ago

Is your enhancement related to a problem? Please describe

QuickPickInput.svelte	CommandPalette.svelte

Describe the solution you'd like

Both are modals, so they should uses the Modal component

⚠️ The current modal implementation does not support custom position (top | bottom | center | left | right) this should probably be added
Both are showing searchable list of items

Describe alternatives you've considered

No response

Additional context

No response

axel7083 commented 6 months ago

My suggestion would be to remove the CommandPalette.svelte and make the logic in the main package, and uses the QuickPickInput.svelte component instead for the commands. The CommandRegistry should probably be able to handle that easily.

Improving the `CommandRegistry`

First I would add the InputQuickPickRegistry in the CommandRegistry class constructor.

I would add a void showCommandPalette() responsible of showing a quick pick with the commands.

cc @benoitf what do you think ? I am currently working on the modals so I can make the change

benoitf commented 6 months ago

@axel7083 I would not do it now, I think there is already an issue about merging CommandPalette into another component, etc.

Command Palette is still currently quite hidden, so I would prefer to focus on the light theme even and probably this one would be done at the very last.

benoitf commented 6 months ago

https://github.com/containers/podman-desktop/issues/4111

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!