pods-framework / pods-beaver-builder-themer-add-on

Integration of Beaver Themer plugin for WordPress (https://pods.io/beaver-themer/)
https://wordpress.org/plugins/pods-beaver-builder-themer-add-on/
GNU General Public License v2.0
35 stars 6 forks source link

Improve Post Module support #71

Open quasel opened 6 years ago

quasel commented 6 years ago

Take a look at PP: Timeline, Content Tiles, ...

Started discussion with the BB/UABB/PP Team how to improve the loop-settings.php To avoid stuff like:

// add additional pods settings to any posts module
    add_action( 'fl_builder_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
    add_action( 'uabb_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
    add_action( 'pp_cg_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
    add_action( 'pp_ct_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );

@Taxonomy Filters: might need JS - trigger when any "pick" Type Field is selected and set the post_type, maybe needs data_source to be triggerd to to get other settings to update!

Seem PP only alllows Taxonomy Filters for - custom_query (mail sent)

if ( $( '.fl-builder-pp-content-grid-settings select[name="data_source"]' ).val() !== 'custom_query' ) {
    return;
}
quasel commented 6 years ago

Be Aware of uabb_loop_query_args() as UABB enforces the PostType