search

podverse / podverse-rn

Podverse mobile app written in React Native for iOS, Android, and F-Droid
https://podverse.fm/about
GNU Affero General Public License v3.0
213 stars 37 forks source link

Support for .mp3/.m4a embedded chapters #895

Open mitchdowney opened 2 years ago

mitchdowney commented 2 years ago

This feature was first requested in podverse-fdroid. Please see the description and screenshot in that ticket, but use this ticket going forward. https://github.com/podverse/podverse-fdroid/issues/47

mitchdowney commented 2 years ago

I think this feature is blocked until chapters can be extracted from ID3 tags in react-native-track-player. https://github.com/doublesymmetry/react-native-track-player/issues/1439

Inrumpo commented 2 years ago

I think this feature is blocked until chapters can be extracted from ID3 tags in react-native-track-player. doublesymmetry/react-native-track-player#1439

This might be the case for .mp3 and .m4a chapters. Podlove Simple Chapters are stored in / written to the RSS feed. Podverse should be able to read them like any other tag.

mitchdowney commented 2 years ago

@Inrumpo good point. I'm going to create a separate issue for PSC chapters since they're fundamentally different than mp3/m4a chapters.

Inrumpo commented 1 year ago

A similar issue has been opened for the popular Pocket Casts Android client that has gone open source lately. Maybe there is or will be some useful insight concerning .m4a chapters: https://github.com/Automattic/pocket-casts-android/issues/393

mitchdowney commented 1 year ago

@Inrumpo thanks for the update. We'd still like to add this, but it's blocked until #1179 is completed. After that is finished, we may have to make a PR into react-native-track-player to extract the chapter data.

mitchdowney commented 1 year ago

I think this is blocked due to react-native-track-player not supporting the ability to grab any metadata tag we want.

https://github.com/doublesymmetry/react-native-track-player/issues/2008

erifneerg commented 5 months ago

From what it seems, the issue has been resovled @mitchdowney in issue doublesymmetry/react-native-track-player# 2118. Hopeful this allows embedded chapters to be used in the app.

mitchdowney commented 5 months ago

@erifneerg wow thanks for the update! It appears according to the release notes that the chapters metadata is only available on iOS, not Android...I'd like to find out why Android isn't supported yet before embarking on feature support for this.

Also, I'm actually thinking seriously about beginning a full rewrite of the mobile app...and possibly the api...and possibly the whole Podverse tech stack 😳 it's over 5 years old at this point, and there are a TON of features in it I never imagined when beginning Podverse (mostly Podcasting 2.0 features).

If we go the full rewrite direction, then I would only be making bug fixes for the existing Podverse mobile app, and would save a new feature like mp3 embedded chapter support for the next version.