Rejected plugin

[PiloudeDakar]

Issue description

I submited my plugin (RankShop) to poggit twice, and it have been rejected and I don't find why. The plugin work, I haven't copied it, and the documentation is good. Is it possible to know why ?

Other information

• Link to repository: https://github.com/PiloudeDakar/RankShop/tree/main/

[VixikHD]

FormAPI should be included as virion

[PiloudeDakar]

Where can i mention it ?

[VixikHD]

Read those rules, I was writing about rule C1b (Stay in your namespace), 'All classes, interfaces and traits declared by plugins must be under this unique namespace (or subnamespaces). This includes libraries bundled with the plugin. Consider using the virion framework, which provides a convenient way of shading libraries (i.e. refactoring libraries into your plugins namespace).'. Although it is under plugin's namespace, reviewers may have problems with that it's not shipped as regular virion. Another problem might be rule C3 (Permission names), 'If the plugin registers permissions, all permission names must start with the plugin name (does not need to contain the author name like the namespace). The permission name should only consist of alphabets, digits, hyphens and dots.' Also they might deny that because plugins EconomyAPI and PurePerms are not supported anymore.

[PiloudeDakar]

I haven't understood how I need to register the lib namespace : namespace PiloudeDakar\RankShop\libs\jojoe77777\FormAPI; isn't good ?

[JaxkDev]

If a plugin has been reviewed you will find a github comment on the commit that was submitted, unless it was approved in which case no github comment will be displayed.

[PiloudeDakar]

Thanks