35 consistent promise handling

[ford-jones]

Definition of Done

For every submission to the codebase, check that it meets the DoD below.

• [x] Code fulfils the user story and scenarios set out in the github task and UI prototype.
• [x] The feature has been thoroughly manually tested. (Ask other devs to give some fresh eyes on this as you go.)
• [x] All tests run and passed from terminal. Any broken tests fixed, not disabled or skipped.

  npm test

• [x] Tests added or updated where appropriate. (Be pragmatic about adding new tests, think; how critical is this module or function? If this function broke due to changes, how would it affect the user experience?)
• [x] eslint run and passes. Any issues fixed.

  npm run lint

• [x] PR created in Github.
• [x] Two peer reviews from other devs.
• [x] One peer review from one of the teachers.
• [ ] After all the peer review comments are addressed, the branch is merged to main!

[EliseWei]

Hi, @frey-mccahon and @ford-jones can you please take a look at the Definition of Done in the PR description and tick off the items that you have completed? It sounds like you might be up to teacher review, but definitely need to make sure the other requirements are met, first, please. :)

[alexcoaton]

Looks like you have a failing test... I'll let you figure this one out.

PASS client client/views/user/Gardens/Events/GardenEvents.test.js
  ✓ garden events should render correct list of events (47 ms)

  console.error
    Error: Uncaught [TypeError: fetchEvent is not a function]

[ford-jones]

@alexcoaton gave us the green light to merge this yesterday so going to put it through now.