30 share event links - Githubissues

xavier-fenton commented 2 years ago

Definition of Done

For every submission to the codebase, check that it meets the DoD below.

[X] Code fulfils the user story and scenarios set out in the github task and UI prototype.
[ ] The feature has been thoroughly manually tested. (Ask other devs to give some fresh eyes on this as you go.)
[X] All tests run and passed from terminal. Any broken tests fixed, not disabled or skipped.

npm test
[X] Tests added or updated where appropriate. (Be pragmatic about adding new tests, think; how critical is this module or function? If this function broke due to changes, how would it affect the user experience?)
[X] eslint run and passes. Any issues fixed.

npm run lint
[X] PR created in Github.
[ ] Two peer reviews from other devs.
[ ] One peer review from one of the teachers.
[ ] After all the peer review comments are addressed, the branch is merged to main!

EliseWei commented 2 years ago

Getting a failing test on this branch. Can you take another look, please? @AL-Qianhe-Lin @xavier-fenton

EliseWei commented 2 years ago

Did this ever get a peer review?

clementine-smart commented 2 years ago

@EliseWei for this one we decided Sophia and I would review it instead. I'm just finishing my review off now