1 photo gallery - Githubissues

Bryden-Gunn commented 2 years ago

Definition of Done

For every submission to the codebase, check that it meets the DoD below.

[x] Code fulfils the user story and scenarios set out in the github task and UI prototype.
[x] The feature has been thoroughly manually tested. (Ask other devs to give some fresh eyes on this as you go.)
[x] All tests run and passed from terminal. Any broken tests fixed, not disabled or skipped.

npm test
[x] Tests added or updated where appropriate. (Be pragmatic about adding new tests, think; how critical is this module or function? If this function broke due to changes, how would it affect the user experience?)
[x] eslint run and passes. Any issues fixed.

npm run lint
[* ] PR created in Github.
[x] Two peer reviews from other devs.
[x] One peer review from one of the teachers.
[x] After all the peer review comments are addressed, the branch is merged to main!

Bryden-Gunn commented 2 years ago

Component test left blank due to unresolved error

alexcoaton commented 2 years ago

I love this guy :P

alexcoaton commented 2 years ago

Nice work on the gallery component! And thanks for fixing up all of the promise handling code.

rongyue1 commented 2 years ago

Reviewed by Yara and Rong