stephencelis
commented
1 year ago @olcayertas Is it possible to share a building project that reproduces the problem?
Without that, I think the problem is here:
internal func handleNewUserStore(_ id: String) {
guard let nc = getNavController() else { return }
guard let index = viewStore.userProfileStates.firstIndex (where: { $0.id == id }) else { return }
showUserProfile(
nc,
store: store.scope(
state: \.userProfileStates[index],
action: { .userProfileAction(id: id, action: $0) }
)
)
}Grabbing an element via the index is an unsafe operation over time. Is it possible to refactor the above using the safer, [id:]-based subscript instead?
olcayertas
Hi I have following case and state and I am trying to clear a state when user dismiss a view controller:
var userProfileStates: IdentifiedArrayOf<User.State> = .init()But I am getting this error with all four of the approaches above:
Swift/ContiguousArrayBuffer.swift:600: Fatal error: Index out of rangeThese are the steps I produce the error:
viewStore .publisher .addedUserState .sink { [weak self] state in self?.handleNewUserStore(state?.id ?? "") } .store(in: &cancellables) ...
internal func handleNewUserStore(_ id: String) { guard let nc = getNavController() else { return } guard let index = viewStore.userProfileStates.firstIndex (where: { $0.id == id }) else { return } showUserProfile( nc, store: store.scope( state: .userProfileStates[index], action: { .userProfileAction(id: id, action: $0) } ) ) }
...
internal func showUserProfile( _ navController: UINavigationController?, store: UserStore ) { guard let parent = viewStore.parentViewController else { return } let view = UserProfileView( store: store, parent: parent, delegate: self ) let controller = UIHostingController(rootView: view) controller.hidesBottomBarWhenPushed = false navController?.pushViewController(controller, animated: true) navController?.setNavigationBarHidden(true, animated: true) }
(lldb) po state.userProfileStates
▿ 1 element ▿ 0 : State
Lib version: 0.5.0
UPDATE: Sending the clear action with a delay partially solved my problem:
This trick solves the problem when user taps to back button and clears out the particular state.
But if I push multiple user screens and tap a different tab bar item, all the sub view controllers are dismissed by tab bar and I should remove all the child states. For this one app still crashes.
Here is the stack trace for the case where user tapped to a tab bar item:
Thread 1 Queue : com.apple.main-thread (serial)
And this is the stack trace for TCA debug tread:
Thread 14 Queue : co.pointfree.ComposableArchitecture.DebugEnvironment (serial)