search

polarblau / capycorder

Chrome extension, generating Capybara request spec steps based on user interaction.
https://chrome.google.com/webstore/detail/niijdolnjmjdjakbanogihdlhcbhfkho
83 stars 15 forks source link

Keep ui after new request #10

Closed simi closed 12 years ago

simi commented 12 years ago

After click on link and page load @ui was not initialized. I tried to fix it.

I was getting:

Error in event handler for 'undefined': TypeError: Cannot call method 'off' of null
    at RecorderUI.<anonymous> (chrome-extension://idhhedhhbjlanahpgjkelklddiijbegb/js/recorder_ui.js:104:16)
    at RecorderUI._hideVisible (chrome-extension://idhhedhhbjlanahpgjkelklddiijbegb/js/recorder_ui.js:4:61)
    at RecorderUI.show (chrome-extension://idhhedhhbjlanahpgjkelklddiijbegb/js/recorder_ui.js:59:19)
    at chrome-extension://idhhedhhbjlanahpgjkelklddiijbegb/js/recorder.js:58:23
    at [object Object].dispatch (extensions/event.js:183:28)
    at extensions/miscellaneous_bindings.js:130:24
    at [object Object].dispatch (extensions/event.js:183:28)
    at Object.<anonymous> (extensions/miscellaneous_bindings.js:177:22)
simi commented 12 years ago

If you want to keep this behavior, it would be nice to avoid this error.

polarblau commented 12 years ago

Absolutely! I've to check what happens there.

polarblau commented 12 years ago

I think you might be right after all on this — merged!