polarismesh / polaris

Service Discovery and Governance Platform for Microservice and Distributed Architecture
https://polarismesh.cn
Other
2.41k stars 399 forks source link

fix: 修复 grpc server panic 日志的 bug #1246

Closed WTIFS closed 1 year ago

WTIFS commented 1 year ago

Please provide issue(s) of this PR: Fixes # 修复问题:grpc server handler 报错时会触发 recover 函数体中的日志;而真正 panic 时不会打 panic 日志

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

Please check any characteristics that apply to this pull request.

polaris-test-bot commented 1 year ago

2023-09-11 15:11:13: =========TEST START========== 2023-09-11 15:47:53: [STANDALONE VERSION]PR autotest FAILED! We executed 47 test cases and 44 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/sta/qta-report.html and https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/sta/ratelimit/qta-report.html 2023-09-11 15:47:56: [CLUSTER VERSION] PR autotest FAILED! We executed 39 test cases and 35 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/clu/qta-report.html 2023-09-11 15:48:00: [KUBENETES VERSION]PR autotest FAILED! We executed 39 test cases and 38 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/k8s/qta-report.html 2023-09-11 15:54:23: =========TEST START========== 2023-09-11 16:23:42: [STANDALONE VERSION]PR autotest FAILED! We executed 47 test cases and 45 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/sta/qta-report.html and https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/sta/ratelimit/qta-report.html 2023-09-11 16:23:46: [CLUSTER VERSION] PR autotest FAILED! We executed 39 test cases and 37 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/clu/qta-report.html 2023-09-11 16:23:50: [KUBENETES VERSION]PR autotest FAILED! We executed 39 test cases and 38 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1509725311/k8s/qta-report.html

codecov[bot] commented 1 year ago

Codecov Report

Merging #1246 (75ed857) into main (97e3066) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files         179      179           
  Lines       32442    32442           
=======================================
+ Hits        18107    18108    +1     
- Misses      11978    11981    +3     
+ Partials     2357     2353    -4     

see 11 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more