polarismesh / polaris

Service Discovery and Governance Platform for Microservice and Distributed Architecture
https://polarismesh.cn
Other
2.41k stars 399 forks source link

Create table and related cache for additional instance data #1262

Open fabian4 opened 1 year ago

fabian4 commented 1 year ago

Please provide issue(s) of this PR: Fixes #1257

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

Please check any characteristics that apply to this pull request.

daheige commented 3 months ago

This design looks good. Please solve the problem of related files. Thank you very much.

daheige commented 2 months ago

please solve these Conflicting files: auth/defaultauth/common_test.go cache/service/instance.go go.mod go.sum store/mock/api_mock.go

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 24.13793% with 66 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (7aace3c) to head (92c12ed).

Files with missing lines Patch % Lines
store/mysql/instance.go 15.87% 49 Missing and 4 partials :warning:
cache/service/instance.go 56.25% 4 Missing and 3 partials :warning:
store/boltdb/instance.go 25.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1262 +/- ## ========================================== - Coverage 50.66% 50.59% -0.08% ========================================== Files 218 218 Lines 34210 34297 +87 ========================================== + Hits 17333 17353 +20 - Misses 14596 14652 +56 - Partials 2281 2292 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.